Remove equivalent NaN float values from diff output #54462
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Nov 8, 2025
Summary: With `opacity` being initialized to NaN for text attributes, not having the NaN check would mean adding the `opacity` prop to the Props 2.0 diff output even when it was unchanged and still set to NaN Changelog: [Internal] Differential Revision: D86577389
lenaic
force-pushed
the
export-D86577389
branch
from
d90a767 to
3869403
Compare
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Nov 10, 2025
Summary: With `opacity` being initialized to NaN for text attributes, not having the NaN check would mean adding the `opacity` prop to the Props 2.0 diff output even when it was unchanged and still set to NaN Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D86577389
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Nov 10, 2025
Summary: With `opacity` being initialized to NaN for text attributes, not having the NaN check would mean adding the `opacity` prop to the Props 2.0 diff output even when it was unchanged and still set to NaN Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D86577389
Summary: With `opacity` being initialized to NaN for text attributes, not having the NaN check would mean adding the `opacity` prop to the Props 2.0 diff output even when it was unchanged and still set to NaN Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D86577389
lenaic
force-pushed
the
export-D86577389
branch
from
3869403 to
c0a7012
Compare
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Nov 10, 2025
Summary: With `opacity` being initialized to NaN for text attributes, not having the NaN check would mean adding the `opacity` prop to the Props 2.0 diff output even when it was unchanged and still set to NaN Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D86577389
|
This pull request has been merged in a7dc9db. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in a7dc9db When will my fix make it into a release? | How to file a pick request? |
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Nov 15, 2025
Summary: Pull Request resolved: facebook/react-native#54462 With `opacity` being initialized to NaN for text attributes, not having the NaN check would mean adding the `opacity` prop to the Props 2.0 diff output even when it was unchanged and still set to NaN Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D86577389 fbshipit-source-id: d0277aaa19b6b5418fa25c9a986c3d4cddb7696f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With
opacitybeing initialized to NaN for text attributes, not having the NaN check would mean adding theopacityprop to the Props 2.0 diff output even when it was unchanged and still set to NaNChangelog: [Internal]
Differential Revision: D86577389